[llvm] r289540 - Fix a buildbot failure introduced by r289538

Artur Pilipenko via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 13 08:38:12 PST 2016


I updated the assertion messages introduced by the original change. See r289545.

Artur

On 13 Dec 2016, at 19:21, Hal Finkel <hfinkel at anl.gov<mailto:hfinkel at anl.gov>> wrote:

----- Original Message -----
From: "Artur Pilipenko via llvm-commits" <llvm-commits at lists.llvm.org<mailto:llvm-commits at lists.llvm.org>>
To: llvm-commits at lists.llvm.org<mailto:llvm-commits at lists.llvm.org>
Sent: Tuesday, December 13, 2016 8:55:31 AM
Subject: [llvm] r289540 - Fix a buildbot failure introduced by r289538

Author: apilipenko
Date: Tue Dec 13 08:55:31 2016
New Revision: 289540

URL: http://llvm.org/viewvc/llvm-project?rev=289540&view=rev
Log:
Fix a buildbot failure introduced by r289538

Build failed because of unused variable in product mode.

Modified:
   llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp

Modified: llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
URL:
http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp?rev=289540&r1=289539&r2=289540&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp (original)
+++ llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp Tue Dec 13
08:55:31 2016
@@ -4469,8 +4469,7 @@ collectByteProviders(SDValue Op, bool Ch
        L->getExtensionType() != ISD::NON_EXTLOAD)
      return None;

-    EVT VT = L->getMemoryVT();
-    assert(BitWidth == VT.getSizeInBits() && "sanity");
+    assert(BitWidth == L->getMemoryVT().getSizeInBits() &&
"sanity");

"sanity" is not a useful message. Maybe, "Extending loads are not supported" or similar would be better?

-Hal


    SmallVector<ByteProvider, 4> Result(ByteWidth);
    for (unsigned i = 0; i < ByteWidth; i++)


_______________________________________________
llvm-commits mailing list
llvm-commits at lists.llvm.org<mailto:llvm-commits at lists.llvm.org>
http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits


--
Hal Finkel
Lead, Compiler Technology and Programming Languages
Leadership Computing Facility
Argonne National Laboratory

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161213/8690c90d/attachment-0001.html>


More information about the llvm-commits mailing list