[PATCH] D27677: [AArch64] Guard Misaligned 128-bit store penalty by subtarget feature

Evandro Menezes via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 13 08:23:22 PST 2016

evandro added a comment.

In https://reviews.llvm.org/D27677#621093, @mssimpso wrote:

> It doesn't look like the feature is limited to v2i64. The fact that the TTI function explicitly checks for an integer type seems wrong to me. But I think Matthias is probably right in that this heuristic was originally intended for Cyclone. It looks fairly clear to me that the heuristic should be guarded by FeatureSlowMisaligned128Store. This will preserve the existing functionality for Cyclone, but will change the other subtargets. Would you have any concerns for Exynos were this the case?

Since this patch qualifies this transformation with `FeatureSlowMisaligned128Store`, I'm comfortable with verifying if Exynos needs this feature or not in a follow up patch, if needed.


More information about the llvm-commits mailing list