[PATCH] D27696: [ThinLTO] Thin link efficiency: skip candidate added later with higher threshold (NFC)

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 12 21:50:08 PST 2016

mehdi_amini added inline comments.

Comment at: lib/Transforms/IPO/FunctionImport.cpp:330
+    bool IsHotCallsite = Edge.second.Hotness == CalleeInfo::HotnessType::Hot;
+    const auto AdjThreshold = GetAdjustedThreshold(Threshold, IsHotCallsite);
mehdi_amini wrote:
> mehdi_amini wrote:
> > I'm fairly lost in the logic here between `GetAdjustedThreshold` and `GetBonusMultiplier`, still trying to make sense of what we're currently doing here.
> OK I figured what's going on, it is quite obscure to infer from the code though, and I believe the comment above is misleading.
(I take back what I wrote for the comment, was looking at the wrong place... So confusing!)


More information about the llvm-commits mailing list