[PATCH] D27551: [DebugInfo] Add regression test for __fp16, float, and double constants.

David Gross via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 12 16:51:51 PST 2016

dgross added inline comments.

Comment at: test/DebugInfo/Generic/static-const-fp.ll:78
+; CHECK: DW_TAG_variable
+; CHECK-NOT: {{^0}}
+; CHECK: DW_AT_name {{.*}} "hVal"
aprantl wrote:
> probinson wrote:
> > To verify that the next attribute is part of the same DIE we usually do:
> > ```
> > ```
> > which shows it's not in a child and not in a DIE from a higher nesting level.
> Alternatively, you can also use CHECK-NEXT, which is often more readable if the match is expected to be on the next line (but not as flexible).
I prefer not to be as strict as requiring the match to be on the next line.  (In fact, it would be better not to require name to precede const_value, but there may not be an easy way to relax that.)


More information about the llvm-commits mailing list