[PATCH] D27686: Add llvm::StringLiteral

Zachary Turner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 12 16:00:14 PST 2016

zturner added a comment.

I actually t

Comment at: include/llvm/ADT/StringRef.h:839
+  /// StringLiteral - A wrapper around a StringLiteral that serves as a proxy
+  /// for constructing global tables of StringRefs with the length computed
yaron.keren wrote:
> wrapper around StringRef
I'm open to better wording here, but I don't think this is accurate either.  A "wrapper around a StringRef" implies that you need a `StringRef` in order to create one of these.  But it's exactly the opposite, you really do need a string literal (i.e. object of the form "abcdefg") to create one of these.


More information about the llvm-commits mailing list