[PATCH] D26556: [InstCombine] don't widen most selects by hoisting an extend

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 12 15:14:25 PST 2016


efriedma added a comment.

If we could pattern-match our way out, it might be okay... but I don't think that's realistic in more complicated cases.  The sign-extend could be pushed forward through another operation or land in a different basic block.  I think it makes more sense to just try to make selects use the "right" width for the target (the width of the compare operands for most targets).


https://reviews.llvm.org/D26556





More information about the llvm-commits mailing list