[PATCH] D27688: [framelowering] Skip dbg values when getting next/previous instruction.

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added a comment.

In general this LGTM, but I wonder if we don't have / shouldn't introduce a more idiomatic way of skipping over DBG_VALUEs.



================
Comment at: lib/Target/X86/X86FrameLowering.cpp:376
+  while (PI != MBB.begin() && PI->isDebugValue())
+    --PI;
+
----------------
Would it make sense to introduce a better API for this? Skipping over all DBG_VALUEs is a pretty common operation.


================
Comment at: test/CodeGen/X86/frame-lowering-debug-intrinsic-2.ll:21
+; CHECK-LABEL: noDebug
+; CHECK: addq  $24, %rsp
+; CHECK: popq  %rbx
----------------
should these be CHECK-NEXTs ?


https://reviews.llvm.org/D27688