[PATCH] D27467: [mips][rtdyld] Move MIPS relocation resolution to a subclass and implement N32 relocations

Simon Atanasyan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 12 12:52:56 PST 2016

atanasyan accepted this revision.
atanasyan added a comment.
This revision is now accepted and ready to land.


Comment at: lib/ExecutionEngine/RuntimeDyld/Targets/RuntimeDyldELFMips.h:20
+class RuntimeDyldELFMips : public RuntimeDyldELF {
sdardis wrote:
> atanasyan wrote:
> > Is it really necessary to move MIPS specific methods into the separate class? What is intention?
> The intention here in creating a separate class to handle MIPS relocations is to simplify resolving N32 relocations in a later patch. Factoring out some of the MIPS specific methods is similar to how other architecture+exe format combinations handle differences.
I'm concerned a bit that the only target requires `RuntimeDyldELF` successor is MIPS. But I do not have any formal objections on this change.


More information about the llvm-commits mailing list