[PATCH] D27466: [SLP] Fix sign-extends for type-shrinking

Michael Kuperstein via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 12 11:36:46 PST 2016

mkuper accepted this revision.
mkuper added a comment.

Still LGTM.

Gerolf / Michael Z, are you ok with continuing the discussion post-commit, if you still have objections?

Gerolf, correct me if I'm wrong, but it sounds like your main issue was not with this patch, but rather with the whole approach to type shortening. 
I believe we should keep it as is, but even if we do end up deciding to remove it, I think we should fix the functional bug we have (PR31243) first.


More information about the llvm-commits mailing list