[PATCH] D27654: Stop intercepting mallinfo and mallopt on FreeBSD
Dimitry Andric via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Dec 12 11:20:50 PST 2016
dim added a comment.
In https://reviews.llvm.org/D27654#620145, @kcc wrote:
> Please add a test.
Hm, what kind of test did you have in mind? It is not useful to test for mallinfo() or mallopt() on FreeBSD, since they never existed in the first place.
> I wonder if it's possible to have fewer ifdefs?
I don't think so, because the symbols should not be defined at all by the sanitizer on FreeBSD. If we just add empty wrappers, those will still be picked up by the linker.
Basically the `#if` statements would now refer to `SANITIZER_INTERCEPT_MALLOPT_AND_MALLINFO`.
More information about the llvm-commits