[PATCH] D27635: [ThinLTO] Import only necessary DICompileUnit fields

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 12 08:08:48 PST 2016

mehdi_amini accepted this revision.
mehdi_amini added a comment.
This revision is now accepted and ready to land.

LGTM. Thanks!

Comment at: lib/Linker/IRMover.cpp:1018
+    return;
+  // When importing for ThinLTO, prevent importing of types listed on
+  // the DICompileUnit that we don't need a copy of in the importing
@aprantl: coding standards page says `Documentation comments for private APIs can go to the implementation file.`

Comment at: lib/Linker/IRMover.cpp:1053
+    // functions they are local to instead of listing them on the CU, and
+    // we would naturally only link in those needed by function importing.
+    SmallVector<TrackingMDNodeRef, 4> AllImportedModules;
@aprantl : the FIXME can be relevant for our work to limit the amount of IR loading.


More information about the llvm-commits mailing list