[PATCH] D27625: [asan] Don't skip instrumentation of masked load/store unless we've seen a full load/store on that pointer.

Filipe Cabecinhas via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 12 06:20:01 PST 2016

filcab added inline comments.

Comment at: lib/Transforms/Instrumentation/AddressSanitizer.cpp:2074
+            continue;  // We've seen this temp in the current BB.
+        }
+        if (ClOpt && ClOptSameTemp && !MaybeMask) {
RKSimon wrote:
> Remove the braces. Any reason why you don't want to merge the if conditions?
Mostly to avoid touching much code. I'll upload a new version.
But I'll keep the braces so we don't have ambiguity with the nested if (after the code change).


More information about the llvm-commits mailing list