[PATCH] D27152: Merge strings using sharded hash tables.

[Rafael Avila de Espindola via llvm-commits]

Sean Silva <chisophugis at gmail.com> writes:
> That is the rule that I am in favor of, but Rafael seems to prefer that
> --threads/--no-threads should not affect the output. Hence we need to come
> to agreement and document the conclusion.

I would appreciated if we tried to avoid the difference. Doing a final
sort on the string number (i.e, when it was first seen) would also allow
dynamically varing how many shards we use, so it might be a good thing
for performance too.

> Also, the wording should be clear that the output *binary* is guaranteed
> the same. We are already nondeterministic w.r.t. the order of user
> diagnostics.

Correct.

Cheers,
Rafael