[PATCH] D27216: [SCEVExpand] do not hoist divisions by zero (PR30935)

Sanjoy Das via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 11 13:38:50 PST 2016


sanjoy added a comment.

In https://reviews.llvm.org/D27216#608859, @sanjoy wrote:

> Hi,
>
> I don't think this patch properly addresses PR30976 -- it only hides the symptom.  For instance, this new test case crashes SCEVExpander even with this fix: https://reviews.llvm.org/differential/diff/79708/


I think I've addressed the underlying problem with r289397 so this (along with the test case above) should be okay to go in, pending review comments.


https://reviews.llvm.org/D27216





More information about the llvm-commits mailing list