[PATCH] D27657: [X86][SSE] Lower suitably sign-extended mul vXi64 using PMULDQ

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 11 13:38:50 PST 2016


RKSimon added inline comments.


================
Comment at: test/CodeGen/X86/vector-compare-results.ll:1884
+; AVX512-NEXT:    # kill: %XMM0<def> %XMM0<kill> %YMM0<kill>
+; AVX512-NEXT:    vmovdqa %xmm4, %xmm2
 ; AVX512-NEXT:    retq
----------------
RKSimon wrote:
> craig.topper wrote:
> > This change seems unrelated to the multiply changes. Was it caused by the computeSignBits changes handling for extract subvector?
> Yes it's down to adding EXTRACT_SUBVECTOR support to computeSignBits
Should I commit the EXTRACT_SUBVECTOR support first to split the diffs?


Repository:
  rL LLVM

https://reviews.llvm.org/D27657





More information about the llvm-commits mailing list