[PATCH] D26224: NewGVN

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 11 13:38:50 PST 2016


RKSimon added a comment.

In https://reviews.llvm.org/D26224#618457, @davide wrote:

> In https://reviews.llvm.org/D26224#618046, @silvas wrote:
>
> > Also, uhm, this needs tests. Maybe you can get away with just adding some more RUN lines to some LegacyGVN tests?
>
>
> Yes, this is my intention. In the non-upstream branch all the tests have another run line which looks like
>  `RUN: opt -newgvn %s | FileCheck %s`. They're not included here just to make the diff smaller.


Might it be possible to create a new phab patch now - dependent on this one that includes the NewGVN activation and test changes? Doesn't affect this initial patch but helps everyone see the upcoming effects on tests.


https://reviews.llvm.org/D26224





More information about the llvm-commits mailing list