[PATCH] D27466: [SLP] Fix sign-extends for type-shrinking

[Matthew Simpson via Phabricator via llvm-commits]

mssimpso added inline comments.


================
Comment at: lib/Transforms/Vectorize/SLPVectorizer.cpp:1936
+      auto *MinTy = IntegerType::get(F->getContext(), MinBWs[ScalarRoot].first);
+      auto ExTy =
+          MinBWs[ScalarRoot].second ? Instruction::SExt : Instruction::ZExt;
----------------
mkuper wrote:
> Could you rename this? ExTy makes it look like a type (yes, it's the "type of the extensions", but...)
Sure, I'll just go with Extend.


================
Comment at: lib/Transforms/Vectorize/SLPVectorizer.cpp:3542
+    // IsSigned is set to True.
+    for (auto *Root : TreeRoot) {
+      IsSigned = !isSignBitKnownZero(Root);
----------------
mkuper wrote:
> Can you use all_of?
Yes, good point.


https://reviews.llvm.org/D27466