[PATCH] D27603: Propagate -fdiagnostics-color to LLD.

[Hans Wennborg via Phabricator via llvm-commits]

hans added inline comments.


================
Comment at: lib/Driver/Tools.cpp:234
                             const ArgList &Args, ArgStringList &CmdArgs,
                             const JobAction &JA) {
   const Driver &D = TC.getDriver();
----------------
Yes, this doesn't seem like exactly the right place, but maybe there is no better one. Perhaps we could add an "addCommonLinkerFlags" function?


================
Comment at: lib/Driver/Tools.cpp:286
+      D.getDiags().getShowColors())
+    CmdArgs.push_back("-color-diagnostics=always");
 }
----------------
This needs a test.

And can we get color diagnostics from lld-link.exe too? That would be nice.


https://reviews.llvm.org/D27603