[PATCH] D26224: NewGVN

Fri Dec 9 05:51:24 PST 2016

As my previous communications on this issue have been off-list with
Davide, I should mention that there is a glitch when the NewGVN is
enabled in a 3-stage bootstrap using a patch like that attached. The
resulting bootstrap fails here on x86_64-apple-darwin15 with...

[  1%] Building AttributesCompatFunc.inc...
cd /sw/src/fink.build/llvm40-4.0.0-1/build/stage2/lib/IR &&
../../bin/llvm-tblgen -gen-attrs -I
/sw/src/fink.build/llvm40-4.0.0-1/llvm-4.0.0.src/lib/IR -I
/sw/src/fink.build/llvm40-4.0.0-1/llvm-4.0.0.src/lib/Target -I
/sw/src/fink.build/llvm40-4.0.0-1/llvm-4.0.0.src/include
/sw/src/fink.build/llvm40-4.0.0-1/llvm-4.0.0.src/lib/IR/AttributesCompatFunc.td
-o /sw/src/fink.build/llvm40-4.0.0-1/build/stage2/lib/IR/AttributesCompatFunc.inc.tmp
0  llvm-tblgen              0x0000000106746606 SignalHandler(int) + 566
1  libsystem_platform.dylib 0x00007fff911a752a _sigtramp + 26
2  llvm-tblgen              0x0000000106762be7
llvm::TGParser::ParseIDValue(llvm::Record*,
std::__1::basic_string<char, std::__1::char_traits<char>,
std::__1::allocator<char> > const&, llvm::SMLoc,
llvm::TGParser::IDParseMode) + 759
3  llvm-tblgen              0x0000000106763c98
llvm::TGParser::ParseSimpleValue(llvm::Record*, llvm::RecTy*,
llvm::TGParser::IDParseMode) + 1096
4  llvm-tblgen              0x0000000106760df4
llvm::TGParser::ParseValue(llvm::Record*, llvm::RecTy*,
llvm::TGParser::IDParseMode) + 36
5  llvm-tblgen              0x00000001067657bd
llvm::TGParser::ParseDeclaration(llvm::Record*, bool) + 621
6  llvm-tblgen              0x0000000106765efb
llvm::TGParser::ParseBodyItem(llvm::Record*) + 379
7  llvm-tblgen              0x00000001067661bb
llvm::TGParser::ParseBody(llvm::Record*) + 123
8  llvm-tblgen              0x0000000106767509
llvm::TGParser::ParseClass() + 553
9  llvm-tblgen              0x000000010676a8f0 llvm::TGParser::ParseFile() + 64
10 llvm-tblgen              0x0000000106747044
llvm::TableGenMain(char*, bool (*)(llvm::raw_ostream&,
llvm::RecordKeeper&)) + 628
11 llvm-tblgen              0x000000010670de66 main + 134
Stack dump:
0. Program arguments: ../../bin/llvm-tblgen -gen-attrs -I
/sw/src/fink.build/llvm40-4.0.0-1/llvm-4.0.0.src/lib/IR -I
/sw/src/fink.build/llvm40-4.0.0-1/llvm-4.0.0.src/lib/Target -I
/sw/src/fink.build/llvm40-4.0.0-1/llvm-4.0.0.src/include
/sw/src/fink.build/llvm40-4.0.0-1/llvm-4.0.0.src/lib/IR/AttributesCompatFunc.td
-o /sw/src/fink.build/llvm40-4.0.0-1/build/stage2/lib/IR/AttributesCompatFunc.inc.tmp
/bin/sh: line 1: 32084 Segmentation fault: 11  ../../bin/llvm-tblgen
-gen-attrs -I /sw/src/fink.build/llvm40-4.0.0-1/llvm-4.0.0.src/lib/IR
-I /sw/src/fink.build/llvm40-4.0.0-1/llvm-4.0.0.src/lib/Target -I
/sw/src/fink.build/llvm40-4.0.0-1/llvm-4.0.0.src/include
/sw/src/fink.build/llvm40-4.0.0-1/llvm-4.0.0.src/lib/IR/AttributesCompatFunc.td
-o /sw/src/fink.build/llvm40-4.0.0-1/build/stage2/lib/IR/AttributesCompatFunc.inc.tmp
make[2]: *** [lib/IR/AttributesCompatFunc.inc.tmp] Error 139
make[1]: *** [lib/IR/CMakeFiles/AttributeCompatFuncTableGen.dir/all] Error 2
make: *** [all] Error 2

It would be nice to get some other eyes on this issue as I am unclear
how many of the developers here do full multi-stage bootstraps in
their daily builds.
                    Jack

On Fri, Dec 9, 2016 at 7:00 AM, Sean Silva via Phabricator
<reviews at reviews.llvm.org> wrote:
> silvas added a comment.
>
> Also, uhm, this needs tests. Maybe you can get away with just adding some more RUN lines to some LegacyGVN tests?
>
>
> https://reviews.llvm.org/D26224
>
>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: llvm40-usenewgvn.patch
Type: text/x-patch
Size: 1799 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161209/64dfe008/attachment.bin>