[PATCH] D25046: AMDGPU: Emit runtime metadata version 2 as YAML

[Sam Kolton via Phabricator via llvm-commits]

SamWot added a comment.

In https://reviews.llvm.org/D25046#617144, @yaxunl wrote:

> In https://reviews.llvm.org/D25046#617142, @SamWot wrote:
>
> > I applied this patch to my repository, but tests aren't working. It seams that llc generate note for metadata, but metadata itself is empty.
> >
> > I'm currently working on adding support for metadata in assembler.
>
>
> The tests are passing in llvm trunk. Are you using llvm trunk with the patch?
>
> How do you plan to represent the metadata as YAML string in assembly?


Yes, I tried with llvm trunk. Did you run tests on windows or linux? For me tests are passing okay on linux but on windows they fail even with latest changes from trunk.

I want to create assembler directives .hsa_code_object_metadata/.end_hsa_code_object_metadata. Between them user can put YAML string that would be directly put to the generated note. E.g.:

  .hsa_code_object_metadata
      {
          amd.MDVersion: [ 2, 0 ]
      }
  .end_hsa_code_object_metadata




https://reviews.llvm.org/D25046