[PATCH] Support: Use a 64-bit seek in raw_fd_ostream::seek().

[Peter Collingbourne via llvm-commits]

Are you looking at the lseek call in the raw_fd_ostream constructor? If so
then I think I agree that the call might not be necessary (we'd have to
look at all call sites to be sure though). But this patch is changing the
call in the seek method.

Peter

On Thu, Dec 8, 2016 at 8:53 PM, Rui Ueyama <ruiu at google.com> wrote:

> It is not clear to me why we have a `lseek` call here in the first place.
> If this code is for "just in case if we are not at beginning of a file",
> I'd rather remove it.
>
> On Thu, Dec 8, 2016 at 8:43 PM, Peter Collingbourne <peter at pcc.me.uk>
> wrote:
>
>> Looks like phab isn't sending mail, so mailing this the old fashioned
>> way. This fixes "lld-link /linkrepro" if the reproducer file happens to be
>> larger than 2GB.
>>
>> Not sure if there's a good way to test this that doesn't involve creating
>> huge files during check-llvm.
>>
>> --
>> --
>> Peter
>>
>
>


-- 
-- 
Peter
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161208/f843b4c8/attachment.html>