[PATCH] D27561: [ELF] Allow output section data commands to take expressions

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 8 15:05:10 PST 2016


ruiu added inline comments.


================
Comment at: ELF/LinkerScript.cpp:868
     if (auto *Data = dyn_cast<BytesDataCommand>(Base.get()))
-      writeInt<ELFT>(Buf + Data->Offset, Data->Data, Data->Size);
+      writeInt<ELFT>(Buf + Data->Offset, Data->Expression(Dot), Data->Size);
 }
----------------
You want to pass `0` instead of `Dot`. When this function is called, `Dot` doesn't have any meaningful value.


https://reviews.llvm.org/D27561





More information about the llvm-commits mailing list