[llvm] r288980 - GlobalISel: simplify MachineIRBuilder interface.

[Tim Northover via llvm-commits]

On 7 Dec 2016, at 18:54, Quentin Colombet <qcolombet at apple.com> wrote:
> One concern I had was that I was afraid the iterator could be invalided by some other insertion/deletion, whereas the pointers are not (unless you delete the related object of course). I admit I didn’t checked the MachineBasicBlock implementation back then, so they may have been unnecessary.
> 
> Do you concur my worries were ill-founded?

I think so. It's a standard ilist iterator so the state is just a pointer to the node (either a MachineInstr or a special sentinel created and destroyed with the MachineBasicBlock). It should be fine (or at least no worse than a direct MachineInstr pointer).

Tim.