[lld] r289025 - [ELF][MIPS] Make _gp, _gp_disp, __gnu_local_gp global symbols

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 8 05:57:22 PST 2016


Simon Atanasyan via llvm-commits <llvm-commits at lists.llvm.org> writes:

>    DefinedRegular<ELFT> *addAbsolute(StringRef Name,
> -                                    uint8_t Visibility = llvm::ELF::STV_HIDDEN);
> +                                    uint8_t Visibility = llvm::ELF::STV_HIDDEN,
> +                                    uint8_t Type = llvm::ELF::STB_GLOBAL);

This argument should be called Binding, not Type.

Cheers,
Rafael


More information about the llvm-commits mailing list