[PATCH] D27512: Move clang's ParseHelper into Support (llvm part)

[Oliver Stannard via Phabricator via llvm-commits]

olista01 added a comment.

I'm going to use this for https://reviews.llvm.org/D27514, adding similar diagnostic verifying functionality to llvm-mc.

I think the name is still accurate, it is a  helper class for writing simple parsers. Do you have a suggestion for a better name?



================
Comment at: include/llvm/Support/ParseHelper.h:53
+
+  const char * const Begin; // beginning of expected content
+  const char * const End;   // end of expected content (1-past)
----------------
hans wrote:
> Does it make sense to have all of these as public members?
The current user of this class uses all of these except for End, because it needs to know the current position in the string for diagnostics, and to read back parts of the string found by SearchClosingBrace.


Repository:
  rL LLVM

https://reviews.llvm.org/D27512