[PATCH] D26785: InstCombine: Fold bitcast of vector to FP scalar

David Majnemer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 7 12:45:31 PST 2016


majnemer accepted this revision.
majnemer added a reviewer: majnemer.
majnemer added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lib/Analysis/ConstantFolding.cpp:103
+  if (auto *VTy = dyn_cast<VectorType>(C->getType())) {
+    // Handle a vector->integer cast.
+    if (isa<IntegerType>(DestTy) || DestTy->isFloatingPointTy()) {
----------------
This comment seems wrong, DestTy can be floating point.


https://reviews.llvm.org/D26785





More information about the llvm-commits mailing list