[PATCH] D27400: [sanitizer] Add a 'print_module_map' flag which prints modules with UUIDs on Darwin

[Filipe Cabecinhas via Phabricator via llvm-commits]

filcab added a comment.

Is it that valuable that we print after every report?



================
Comment at: lib/sanitizer_common/sanitizer_flags.inc:79
+            "OS X only. 0 = don't print, 1 = print only once before process "
+            "exits, 2 = print after each report.")
 COMMON_FLAG(bool, check_printf, true, "Check printf arguments.")
----------------
You're not honouring the `2` value under ASan.


================
Comment at: lib/sanitizer_common/sanitizer_mac.cc:862
+  // Now convert to uppercase.
+  while (*out) {
+    *out = toupper(*out);
----------------
Should we add 'X' format conversion to internal_snprintf?


Repository:
  rL LLVM

https://reviews.llvm.org/D27400