[PATCH] D27457: [globalisel] Tablegen-erate PartialMapping*/ValueMapping*/BankIDToCopyMapIdx.

[Diana Picus via Phabricator via llvm-commits]

rovka added inline comments.


================
Comment at: utils/TableGen/RegisterBankEmitter.cpp:252
 
 void RegisterBankEmitter::emitRegisterBankInfoImplementation(
     raw_ostream &OS, StringRef TargetName,
----------------
This function is growing a bit long, could you split it up a bit?


================
Comment at: utils/TableGen/RegisterBankEmitter.cpp:266
+    for (const auto &PartialMappingSize : Bank.partial_mappings())
+      OS << "  PMI_" << Bank.getName() << PartialMappingSize << ",\n";
+
----------------
These used to start at 1, they will start at 0 now - is this intentional?


================
Comment at: utils/TableGen/RegisterBankEmitter.cpp:270
+  for (const auto &Bank : Banks) {
+    if (Bank.partial_mappings().begin() != Bank.partial_mappings().end()) {
+      if (FirstEmittedBank == nullptr)
----------------
Bank.hasPartialMappings()?


https://reviews.llvm.org/D27457