[PATCH] D27339: [globalisel][aarch64] Make getCopyMapping() take register banks ID's rather than IsGPR booleans

[Diana Picus via Phabricator via llvm-commits]

rovka added inline comments.


================
Comment at: lib/Target/AArch64/AArch64GenRegisterBankInfo.def:147
+  PMI_FirstGPR, // GPR
+  PMI_None,
+};
----------------
Why is this last member needed? Isn't it invalid to access it in the first place?


================
Comment at: lib/Target/AArch64/AArch64GenRegisterBankInfo.def:155
 /// If \p DstIsGPR is true, the destination of the copy is on GPR,
 /// otherwise it is on FPR. Same thing for \p SrcIsGPR.
 const RegisterBankInfo::ValueMapping *
----------------
You should update the comment.


https://reviews.llvm.org/D27339