[PATCH] D27490: Add CTMark directory to test-suite

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 6 16:14:56 PST 2016


MatzeB created this revision.
MatzeB added a reviewer: cmatthews.
MatzeB added a subscriber: llvm-commits.
MatzeB set the repository for this revision to rL LLVM.
Herald added subscribers: mgorny, mcrosier.

This is a proposal to make CTMark an explicit entity in the test-suite. Some notes:

- You can use this with `cmake -DTEST_SUITE_SUBDIRS=CTMark`
- It cannot be used in combination with SingleSource or MultiSource benchmarks (duplicate targets)
- The usage of symlinks makes the benchmarks comprising CTMark obvious while reusing the existing CMakeLists.txt of these benchmarks.
- Symlink usage may be problematic on windows (but does the test-suite work properly on windows anyway?)
- The way this is setup will miss intermediate CMakeLists.txt (i.e. if someone adds CPPFLAGS in say MultiSource/Benchmarks/CMakeLists.txt we will miss that because we include MultiSource/Benchmarks/tramp3d-v4/CMakeLists.txt directly)

I believe none of the problems are big enough to not do this. But would be nice to hear some opinions.


Repository:
  rL LLVM

https://reviews.llvm.org/D27490

Files:
  CMakeLists.txt
  CTMark/7zip
  CTMark/Bullet
  CTMark/CMakeLists.txt
  CTMark/ClamAV
  CTMark/README.md
  CTMark/SPASS
  CTMark/consumer-typeset
  CTMark/kimwitu++
  CTMark/lencod
  CTMark/mafft
  CTMark/sqlite3
  CTMark/tramp3d-v4

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D27490.80499.patch
Type: text/x-patch
Size: 3540 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161207/a91e5fe1/attachment.bin>


More information about the llvm-commits mailing list