[PATCH] D27467: [mips][rtdyld] Move MIPS relocation resolution to a subclass and implement N32 relocations

[Simon Atanasyan via Phabricator via llvm-commits]

atanasyan added inline comments.


================
Comment at: lib/ExecutionEngine/RuntimeDyld/RuntimeDyldELF.cpp:15
 #include "RuntimeDyldELF.h"
+#include "Targets/RuntimeDyldELFMips.h"
 #include "RuntimeDyldCheckerImpl.h"
----------------
Unsorted include directives.


================
Comment at: lib/ExecutionEngine/RuntimeDyld/RuntimeDyldELF.h:88
 
+protected:
   size_t getGOTEntrySize();
----------------
Are this and similar changes below mandatory for this patch? Maybe move them into separate commit?


================
Comment at: lib/ExecutionEngine/RuntimeDyld/Targets/RuntimeDyldELFMips.cpp:1
+//===-- RuntimeDyldELFMips.h ---- ELF/Mips specific code. -------*- C++ -*-===//
+//
----------------
s/h/cpp/


================
Comment at: lib/ExecutionEngine/RuntimeDyld/Targets/RuntimeDyldELFMips.h:20
+
+class RuntimeDyldELFMips : public RuntimeDyldELF {
+public:
----------------
Is it really necessary to move MIPS specific methods into the separate class? What is intention?


Repository:
  rL LLVM

https://reviews.llvm.org/D27467