[PATCH] D27238: [libFuzzer] Diff 7 - Improve Signal Handler interface.

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 6 14:04:32 PST 2016


rnk added a comment.

In https://reviews.llvm.org/D27238#614137, @kcc wrote:

> Dunno. As is the change increases the code size w/o solving any problem.


The problem, as I see it, is that SetSigFooHandler pattern exposes the wrong cross-platform API. On Windows, we will install exactly one exception handler, switch on the exception code, and then decide whether to catch it based on the user's options.

Would you be OK with this direction if we had a struct of bools instead of a struct of callbacks?


Repository:
  rL LLVM

https://reviews.llvm.org/D27238





More information about the llvm-commits mailing list