[PATCH] D27312: Remove MSVC workaround for AlignedCharArray (NFC)

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a comment.

This whole type is basically a lie, though. 32-bit MSVC only ever aligns objects passed by value to 4 bytes. MSVC will issue an error if you try to pass something with __declspec(align) by value. This ifdef effectively works around that diagnostic, but fails to accomplish the goal of alignment.

If we ever depend on the alignment of these objects when they are passed by value, we are screwed. The only thing that saves us today is that we don't often pass highly aligned things by value.

So, there is more work to do here.


Repository:
  rL LLVM

https://reviews.llvm.org/D27312