[PATCH] D27458: [ELF] - Teach LLD to recognize PT_OPENBSD_BOOTDATA

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 6 08:54:39 PST 2016


grimar added inline comments.


================
Comment at: test/ELF/linkerscript/openbsd-bootdata.s:2-4
+# RUN: echo "PHDRS { text PT_LOAD FILEHDR PHDRS; boot PT_OPENBSD_BOOTDATA; } \
+# RUN:       SECTIONS { . = SIZEOF_HEADERS; \
+# RUN:         .text : { *(.text) } \
----------------
ruiu wrote:
> Why did you need .text?
> 
> Also, please do not use line continuations (\) in echo. It makes output messages hard to read when this test fails.
Right, I think i do not need anything except what is in current diff, we can just check that lld creates header.


https://reviews.llvm.org/D27458





More information about the llvm-commits mailing list