[PATCH] D27465: Use the fallible llvm::Regex constructor in Clang.

David L. Jones via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 6 08:41:38 PST 2016


dlj created this revision.
dlj added reviewers: rsmith, llvm-commits.

This change updates Clang to check for an llvm::Expected<llvm::Regex>, instead
of constructing an invalid Regex and checking .isValid().

Since most of the uses already (silently) ignore invalid llvm::Regex objects,
I've not tried too hard to propagate construction-time errors.


https://reviews.llvm.org/D27465

Files:
  change-namespace/ChangeNamespace.cpp
  clang-tidy/ClangTidyDiagnosticConsumer.cpp
  clang-tidy/google/TodoCommentCheck.cpp
  clang-tidy/misc/ArgumentCommentCheck.cpp
  clang-tidy/modernize/AvoidBindCheck.cpp
  clang-tidy/readability/IdentifierNamingCheck.cpp
  clang-tidy/readability/NamespaceCommentCheck.cpp
  include-fixer/find-all-symbols/HeaderMapCollector.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D27465.80428.patch
Type: text/x-patch
Size: 8351 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161206/46fc448e/attachment-0001.bin>


More information about the llvm-commits mailing list