[PATCH] D27448: Add missing parens in assert.

Sam McCall via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 6 03:03:48 PST 2016


(Oops, I meant to just commit this directly since it's a trivial fix. Sorry
for the noise!)

On Tue, Dec 6, 2016 at 11:21 AM, Sam McCall via Phabricator <
reviews at reviews.llvm.org> wrote:

> sammccall created this revision.
> sammccall added a subscriber: llvm-commits.
>
> Add missing parens in assert, which warn in GCC.
>
>
> https://reviews.llvm.org/D27448
>
> Files:
>   lib/CodeGen/GlobalISel/MachineIRBuilder.cpp
>
>
> Index: lib/CodeGen/GlobalISel/MachineIRBuilder.cpp
> ===================================================================
> --- lib/CodeGen/GlobalISel/MachineIRBuilder.cpp
> +++ lib/CodeGen/GlobalISel/MachineIRBuilder.cpp
> @@ -169,7 +169,7 @@
>                                                      const ConstantInt
> &Val) {
>    LLT Ty = MRI->getType(Res);
>
> -  assert(Ty.isScalar() || Ty.isPointer() && "invalid operand type");
> +  assert((Ty.isScalar() || Ty.isPointer()) && "invalid operand type");
>
>    const ConstantInt *NewVal = &Val;
>    if (Ty.getSizeInBits() != Val.getBitWidth())
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161206/a85f58a4/attachment.html>


More information about the llvm-commits mailing list