[PATCH] D27374: [PM] Rename lookupPass to lookUpPass.

[Sean Silva via Phabricator via llvm-commits]

silvas added a comment.

In https://reviews.llvm.org/D27374#613686, @jlebar wrote:

> > if you're renaming this better to rename it lookUpAnalysis.
>
> I left it as "lookUpPass" because a lot of the analysis code talks about "passes", or sometimes "analysis passes".
>
> Should we excise mentions of "pass" from the analysis parts?  I can write that patch if you think it's the terminology we want to adopt.


Check with Chandler, but "pass" is really an old-PM concept. The new-PM has analyses and transformations. Sure, we can call them "analysis passes" and "transformation passes" but then what does "pass" by itself mean? It doesn't mean anything. In fact, the only thing that I can think of which is shared between analyses and transformations is `PassInfoMixin` but it feels incidental; it's just a mixin for adding a `name` method to get the class name and there are currently no transformation-specific things needed in that mixin so it gets reused for analyses.


Repository:
  rL LLVM

https://reviews.llvm.org/D27374