[PATCH] D27386: build: add support for standalone lld build

[Saleem Abdulrasool via Phabricator via llvm-commits]

compnerd added a comment.

Thanks for the review!



================
Comment at: CMakeLists.txt:16
+                  RESULT_VARIABLE HAD_ERROR
+                  OUTPUT_VARIABLE LLVM_CONFIG_OUTPUT
+                  OUTPUT_STRIP_TRAILING_WHITESPACE)
----------------
beanz wrote:
> Since you're only outputting one field now you should be able to just write the result directly into `OBJ_ROOT`. Then you can get rid of the string processing below.
Sure, Ill simplify it.  I thought keeping it generic would be good.  But, given that we want to modernise the usage here, it makes sense to simplify and then replace it across all the projects.


================
Comment at: CMakeLists.txt:44
+
+  set(LLVM_RUNTIME_OUTPUT_INTDIR ${CMAKE_BINARY_DIR}/${CMAKE_CFG_INTDIR}/bin)
+  find_program(LLVM_TABLEGEN_EXE "llvm-tblgen" ${LLVM_TOOLS_BINARY_DIR} NO_DEFAULT_PATH)
----------------
beanz wrote:
> Do you need to define `LLVM_LIBRARY_OUTPUT_INTDIR` or `LLVM_SHLIB_OUTPUT_INTDIR`?
It wouldnt hurt to define them, however, they are not currently used by the lld build afaik.


Repository:
  rL LLVM

https://reviews.llvm.org/D27386