[PATCH] D26718: [llvm] Iterate SmallPtrSet in reverse order to uncover non-determinism in codegen

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: include/llvm/ADT/SmallPtrSet.h:30
+#if LLVM_ENABLE_ABI_BREAKING_CHECKS
+extern bool ReverseIterate;
+#endif
----------------
mgrang wrote:
> mgrang wrote:
> > mehdi_amini wrote:
> > > This introduces a dependency from ADT to Support, I'm not sure it is OK.
> > > Also the symbol should be in the LLVM namespace.
> > @mehdi_amini Yes, I will move ReverseIterate to LLVM namespace.
> > 
> > Initially I was skeptical about defining ReverseIterate in Support. But then I did not know of a better place to do this, Could you please suggest what would be a preferable place to define this?
> @mehdi_amini Could you please take a look at my updated patch and comment when you get a chance?
I don't have a good suggestion. This is quite annoying. Maybe making them weak definition in a header (possibly using template)?


https://reviews.llvm.org/D26718