[PATCH] D27028: Add intrinsics for constrained floating point operations

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 5 17:42:57 PST 2016


arsenm added a comment.

In https://reviews.llvm.org/D27028#614081, @andrew.w.kaylor wrote:

> Fixed typos and style issues.
>  Added FIXME comments as requested.
>
> I have opened two Bugzilla reports.
>
> One to add FP environment register modeling:
>  https://llvm.org/bugs/show_bug.cgi?id=31284
>
> One to address denormal handling:
>  https://llvm.org/bugs/show_bug.cgi?id=31285
>
> I'd like to talk more about the denormal handling apart from this review.  I'm not certain that rolling it into these intrinsics is the correct solution.  It might be, and I'd be happy to do that if we agree that's the best approach.  It seems to me as though it has certain similarities to the fast math flags as well, so I'd like to talk about that relationship a bit.


Correct handling of ftz is  required for correctness, so it isn't appropriate to be an optimization hint placed with the fast math flags


Repository:
  rL LLVM

https://reviews.llvm.org/D27028





More information about the llvm-commits mailing list