[PATCH] D23303: LiveIntervalAnalysis: fix a crash in repairOldRegInRange

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 5 16:09:43 PST 2016


MatzeB added inline comments.


================
Comment at: llvm/trunk/lib/CodeGen/LiveIntervalAnalysis.cpp:1399-1403
+  if (LII == LR.begin()) {
+    // This happens when the function is called for a subregister that only
+    // occurs _after_ the range that is to be repaired.
+    return;
+  }
----------------
I am not sure this is correct.

This seems to hit all cases where the first live segments ends after `endIdx`, though the comment sounds like it wants to hit the cases where the first live segments begins after `endIdx`.


Repository:
  rL LLVM

https://reviews.llvm.org/D23303





More information about the llvm-commits mailing list