[PATCH] D27397: [LAA] Prevent invalid IR for loop-invariant bound in loop body

Adam Nemet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 5 10:07:16 PST 2016


anemet accepted this revision.
anemet added a comment.
This revision is now accepted and ready to land.

LGTM with the comments below.  Thanks for the fix!



================
Comment at: test/Analysis/LoopAccessAnalysis/loop-invariant-bound.ll:1
+; RUN: opt -loop-vectorize -S < %s | FileCheck %s
+; Checks that when introducing memcheck, LAA does not accidentally introduce non-dominating instructions
----------------
This test should probably be formulated with -loop-versioning under Transform/LoopVersioning


================
Comment at: test/Analysis/LoopAccessAnalysis/loop-invariant-bound.ll:4
+target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
+target triple = "x86_64-unknown-linux-gnu"
+
----------------
No need to specify the target triple.


https://reviews.llvm.org/D27397





More information about the llvm-commits mailing list