XRay-aarch64-linux::patching-unpatching.cc test flaky

Renato Golin via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 5 09:36:07 PST 2016


On 5 December 2016 at 17:19, x y <serge.rogatch at gmail.com> wrote:
> I've tried what I could troubleshooting the issue. My AArch64 XRay code is
> quite short, so the only issue I can spot now happens when __arm__ and
> __aarch64__ are defined simultaneously. Shall I submit a fix for better
> handling this case, or should it really never happen?

Hum, __arm__ should not be defined on AArch64, but I remember having a
similar problem in compiler-rt.

Can you use #elsif defined(__aarch64__) ?


> I'm going to disable the test with the approach suggested by Renato. Sorry
> it took so long, I tried to fix the issue first. And of course, I cannot
> reproduce it locally.

Ok, LGTM. Thanks!

--renato


More information about the llvm-commits mailing list