[PATCH] D26367: Fix DAGCombiner match

[James Molloy via Phabricator via llvm-commits]

jmolloy added a comment.

Hi Evgeny,

> There are no new fails on LLVM LIT tests.

The LLVM LIT tests are essentially unit tests so provide a quick indication that something is broken. The test-suite is a series of actual programs and benchmarks that provide a more rigorous correctness and performance test.

The test-suite can be run via LNT - see here for example: http://llvm.org/docs/lnt/quickstart.html#running-tests . For this change, I'm worried about the potential impact of the change beyond the regression test you've written, so I'd prefer if you could run performance testing and check there are no major performance regressions. (Make sure you use -j1 when invoking LNT for this, otherwise you'll end up with noisy results! also use --multisample to get an idea of the variance as some tests can vary wildly).

> For this I can get only X86 results. Is this ok?

That's fine - X86 is the only hardware that we can reasonably expect everyone to have access to.


Repository:
  rL LLVM

https://reviews.llvm.org/D26367