[PATCH] D27335: [ELF] Print file:line for unknown PHDR error

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 2 15:29:12 PST 2016


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: test/ELF/linkerscript/phdrs.s:43
+# RUN: echo "PHDRS {all PT_LOAD FILEHDR PHDRS ;} \
+# RUN:       SECTIONS { \
+# RUN:           . = 0x10000200; \
----------------
grimar wrote:
> Looks this can be single line
> 
> ```
> SECTIONS { .foo : {*(.foo.*)} :foo }" > %t.script
> ```
Yes, but please avoid `foo` everywhere, and instead use foo bar and baz, so that we know which foo when foo is displayed.


Repository:
  rL LLVM

https://reviews.llvm.org/D27335





More information about the llvm-commits mailing list