[PATCH] D26083: [LV] Scalarize operands of predicated instructions

Matthew Simpson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 2 10:54:46 PST 2016


mssimpso updated this revision to Diff 80099.
mssimpso marked 3 inline comments as done.
mssimpso added a comment.

Addressed comments from Michael and Gil.

- Added documentation requested by Michael.
- Added a needsExtract condition for determining if we need to compute a scalarization overhead, as mentioned by Gil. I updated some costs in the AArch64/predication_costs.ll test to reflect this. For predicated stores, we know their GEP pointer operands will be scalar, so we no longer will calculate an extract cost for them.


https://reviews.llvm.org/D26083

Files:
  lib/Transforms/Vectorize/LoopVectorize.cpp
  test/Transforms/LoopVectorize/AArch64/aarch64-predication.ll
  test/Transforms/LoopVectorize/AArch64/predication_costs.ll
  test/Transforms/LoopVectorize/X86/x86-predication.ll
  test/Transforms/LoopVectorize/if-pred-non-void.ll
  test/Transforms/LoopVectorize/if-pred-stores.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D26083.80099.patch
Type: text/x-patch
Size: 28141 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161202/de5b78f9/attachment.bin>


More information about the llvm-commits mailing list