[llvm] r288424 - [ADT, Support, TableGen] Fix some Clang-tidy modernize-use-default and Include What You Use warnings; other minor fixes (NFC).

[Eugene Zelenko via llvm-commits]

On Fri, Dec 2, 2016 at 1:46 AM, Malcolm Parsons
<malcolm.parsons at gmail.com> wrote:
>>  protected:
>>    // Workaround Clang PR22793
>> -  ~basic_parser() {}
>> +  ~basic_parser() = default;
>>  };
>
> PR22793 is about clang 3.6 crashing on class templates with defaulted
> protected destructors.
>
> If the workaround is still needed then revert this.
> Otherwise, remove the comment.

http://llvm.org/docs/GettingStarted.html#host-c-toolchain-both-compiler-and-standard-library
lists Clang 3.1 as minimum required version.

But buildbots didn't found problem. It may mean that buildbots use
recent versions of Clang, or somehow error was fixed in 3.6 or its
late versions.

If former is true, there is  more generic question: how we could
enforce minimum required version of Clang with all its shortcomings if
we don't have buildbots which use it.

Eugene.