[PATCH] D26671: Replace APFloatBase static fltSemantics data members with getter functions

Stephan Bergmann via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 2 00:20:59 PST 2016


sberg added a comment.

In https://reviews.llvm.org/D26671#611268, @timshen wrote:

> As far as I can tell, Clang actively uses these semantics, so I expect this change to break clang build. Do you have other patches to adjust other repositories?


see my previous: "Checked additional repos tools/clang and tools/clang/tools/extra (which each needs a corresponding patch, which I'll submit once the details of this one are discussed), projects/libcxxabi (which mentions those data members' mangled names in test/test_demangle.pass.cpp, but apparently only as sample test data, so doesn't need changing?), projects/libcxx, and project/compiler-rt (which are unaffected). Is there a list of more repos to check? (And how would commits for such an incompatible cross-repo change be done atomically?)"

> I don't know if it's necessary, but it's better to have them checked in in a single svn commit.

How do I do that?  Any pointer?


https://reviews.llvm.org/D26671





More information about the llvm-commits mailing list