[PATCH] D26594: IR: Change the gep_type_iterator API to avoid always exposing the "current" type.

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 1 14:46:34 PST 2016


dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

I'd probably be inclined to add some comments about how this API's a bit weird and could be more offset-focussed (including the gotchas/places where that doesn't quite hold (you were saying about the outer structness being interesting - though I couldn't quite follow how/why)) in a non-doc comment at the top of the class.

But if not, people might still find this discussion in the code review. Thanks for your patience.


https://reviews.llvm.org/D26594





More information about the llvm-commits mailing list