[PATCH] D25200: [InstCombine] New opportunities for FoldAndOfICmp and FoldXorOfICmp

Ehsan Amiri via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 1 11:52:31 PST 2016


amehsan added a comment.

In https://reviews.llvm.org/D25200#610857, @spatel wrote:

> In https://reviews.llvm.org/D25200#610847, @amehsan wrote:
>
> > You are right (I just tried it :-) If that is the only concern is it possible to approve this and I will remove that line from the switch stmt. (I think it does not hurt to leave the testcases though) and commit.
>
>
> Yes, it's good to keep the tests to make sure the underlying assumption doesn't break.
>  LGTM - although I don't think we need a switch for just 2 cases. :)


Sure :-) Will change it to if statement after removing UGT


https://reviews.llvm.org/D25200





More information about the llvm-commits mailing list